Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e golden testing for csv command #102

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Conversation

Bobgy
Copy link
Collaborator

@Bobgy Bobgy commented Jan 22, 2022

Set up golden file testing for go-licenses csv command on example modules.
Update golden files by running: go test --update .

The example modules are copied from

4 added examples:

  • hello01 - hello world module with no dependencies
  • cli02 - module that have dependencies similar to a CLI tool generated by cobra
  • vendored03 - module that vendors its dependencies
  • replace04 - module using replace directive

Generated licenses.csv golden files will be good examples to demonstrate new features implemented in the v2 proposal: #70 and ensure that there are no regressions.

@Bobgy
Copy link
Collaborator Author

Bobgy commented Jan 22, 2022

@wlynch for review

Copy link
Contributor

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, just minor comments.

e2e_test.go Outdated Show resolved Hide resolved
e2e_test.go Outdated Show resolved Hide resolved
@Bobgy Bobgy force-pushed the e2e-snapshots branch 2 times, most recently from 1214633 to d23f931 Compare February 24, 2022 01:26
@Bobgy Bobgy requested a review from wlynch February 24, 2022 01:28
@wlynch wlynch merged commit 50d4426 into google:master Feb 24, 2022
@Bobgy Bobgy deleted the e2e-snapshots branch February 25, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants